From: Hirokazu Takahashi Hi Dave, Would you apply the following patch right after the previous patch to clean up the code. > The attached patch is against linux-2.6.10-rc1-mm5-mhp1 . > It can be applied right after P20-nowriteback.patch . > > P20-nowriteback.patch had 2 problems. > > generic_move_buffer() invokes lock_buffer() which might > block the caller, even if it already grabs a spin-lock against > page->mapping->private_lock. AFAIK, the problem hasn't > occurred though. > > The another problem is "calling unlock_page_buffer() if > PagePrivate()". This assumption is ok for ordinary filesystems > including ext2 and ext3. But it's not true for some filesystems, > as they might use page->private for their own use. > > The patch will fix the problems. Please apply it before you start > to implement migrate_page methods for other filesystems. > > Thanks, > Hirokazu Takahashi. Signed-off-by: Hirokazu Takahashi Signed-off-by: Dave Hansen --- fs/buffer.c | 0 1 files changed diff -puN fs/buffer.c~P20-nowriteback-cleanup-lock fs/buffer.c _