From: Dave Hansen <dave.hansen@linux.intel.com>
To: dave.hansen@linux.intel.com
Subject: Re: [PATCH v9 21/23] x86/virt/tdx: Enable TDX module runtime updates
In-Reply-To: <20260513151045.1420990-22-chao.gao@intel.com>
References: <20260513151045.1420990-22-chao.gao@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[Draft review generated by x86-maintainer-agent applying Dave_Hansen.txt
 rules to the v9 series.  Strip this banner before sending.]

> -	/* To be enabled when kernel is ready. */
> -	return false;
> +	return sysinfo->features.tdx_features0 & TDX_FEATURES0_TD_PRESERVING;

This is the "the kernel is ready" flip.  If you take the suggestion
on 08/23 (introduce tdx_supports_runtime_update() at this commit and
hardcode `false` inline in 08/23), this patch becomes the
introduction patch instead of an enable-the-stub patch and the
intermediate "dead predicate" period goes away.

The TDX_FEATURES0_TD_PRESERVING #define is added here next to its
sole user.  Good -- and the BIT_ULL is correct.

Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>  [with the
                                                        08/23 reshuffle]